Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyMJCF enable attachment without wrapping body #412

Closed
wants to merge 5 commits into from

Conversation

guyazran
Copy link

@guyazran guyazran commented Jul 10, 2023

  • attach method now has an additional argument exclude_wrapper_body.
    • set to False for previous behavior
    • set to True for new behavior
  • internal elements of attachment are positioned and rotated relative to the attachment site.
  • aggregated rotation converters to quaternions for relative rotation
  • implemented xyaxes_to_quat conversion method
  • improved implementation of euler_to_rmat that handles all supported eulerseq values
  • implemented generic function wrapper for mju rotation conversions that

resolves #407

@google-cla
Copy link

google-cla bot commented Jul 10, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@guyazran
Copy link
Author

guyazran commented Aug 3, 2023

I realized this implementation is messy and convoluted, and doesn't even support detachment. I now understand the design choice of wrapping the contents within attachment frames, I don't think there is a quick fix that will support my desired functionality. I am closing this PR

@guyazran guyazran closed this Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyMJCF Attachment frame extra body breaks compilation of freejoint object attachments
1 participant