feat: accept docker daemon host via flag #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes goodwithtech#170 Signed-off-by: Batuhan Apaydın <[email protected]> Co-authored-by: Furkan Türkal <[email protected]> Signed-off-by: Batuhan Apaydın <[email protected]>
|
kindly ping @tomoyamachi 🙋🏻♂️ |
Signed-off-by: Batuhan Apaydın <[email protected]>
developer-guy
force-pushed
the
master
branch
from
a183709
to
2930f68
Compare
tomoyamachi
reviewed
Feb 16, 2022
| if xdgRuntimeDir != "" { | ||
| dockerSockPath = fmt.Sprintf("unix://%s/docker.sock", xdgRuntimeDir) | ||
| } else { | ||
| dockerSockPath = "unix:///var/run/docker.sock" |
There was a problem hiding this comment.
You can set an empty string if XDG_RUNTIME_DIR is not set. So, this line looks unnecessary.
There was a problem hiding this comment.
yes, but having it in a variable can help to understand what is going to be the default value of the Docker daemon's socket path, WDYT?
|
@developer-guy Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #170
Signed-off-by: Batuhan Apaydın [email protected]
Co-authored-by: Furkan Türkal [email protected]