Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to run Dockle programmatically #162

Merged
merged 2 commits into from
Nov 3, 2021
Merged

Add the option to run Dockle programmatically #162

merged 2 commits into from
Nov 3, 2021

Conversation

lior-orca
Copy link
Contributor

When consuming Dockle as a go module, there is currently no way of running it easily.
The introduction of a public "Dockle CLI creator" will enable that

@lior-orca
Copy link
Contributor Author

Hi @tomoyamachi,
Can you please review the change?
Thanks in advance

@lior-orca
Copy link
Contributor Author

@tomoyamachi what is the status of this PR?
can someone from the core contributors check it?

NewDockleCli Factory for Dockle CLI creation.
An Enabler for programmatic usage of Dockle
*/
func NewDockleCli() *cli.App {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks cool to name this function NewApp().
You can use it as app := dockle.NewApp().

Copy link
Collaborator

@tomoyamachi tomoyamachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@tomoyamachi tomoyamachi merged commit 09a495f into goodwithtech:master Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants