Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vg/{fonts,vgpdf}: remove vg/fonts package #728

Merged
merged 2 commits into from
Aug 19, 2021

Conversation

sbinet
Copy link
Member

@sbinet sbinet commented Aug 17, 2021

Use embedded characted encoding table for embedded fonts.
This relies on Go >= 1.16 for the "embed" package.

Fixes #696.
Fixes #637.

Please take a look.

Use embedded characted encoding table for embedded fonts.
This relies on Go >= 1.16 for the "embed" package.

Fixes gonum#696.
Fixes gonum#637.
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2021

Codecov Report

Merging #728 (bc92784) into master (fc63b2a) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #728      +/-   ##
==========================================
- Coverage   73.20%   73.14%   -0.07%     
==========================================
  Files          56       58       +2     
  Lines        5158     5366     +208     
==========================================
+ Hits         3776     3925     +149     
- Misses       1197     1248      +51     
- Partials      185      193       +8     
Impacted Files Coverage Δ
vg/vgpdf/vgpdf.go 69.86% <ø> (+0.35%) ⬆️
vg/vggio/context.go 100.00% <0.00%> (ø)
vg/vggio/vggio.go 67.37% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc63b2a...bc92784. Read the comment docs.

@sbinet
Copy link
Member Author

sbinet commented Aug 19, 2021

PTAL

@sbinet sbinet merged commit 8e09f15 into gonum:master Aug 19, 2021
@sbinet sbinet deleted the vgpdf-use-embed branch August 19, 2021 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vg: remove {Add,Make}Font vg/fonts: support //go:embed directives
3 participants