-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #153: creation/update of root categories #157
Merged
goniszewski
merged 3 commits into
goniszewski:develop
from
gpoussel:153-fix-create-update-root-categories
Dec 9, 2024
Merged
Fix issue #153: creation/update of root categories #157
goniszewski
merged 3 commits into
goniszewski:develop
from
gpoussel:153-fix-create-update-root-categories
Dec 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: release v0.4.1-hotfix.3 * fix(data-migration): early return if no categories have parents (goniszewski#128) Signed-off-by: Robert Goniszewski <[email protected]> * Closes goniszewski#130 (goniszewski#131) Signed-off-by: Robert Goniszewski <[email protected]> * fix(database): use dynamic path for SQLite database file Signed-off-by: Robert Goniszewski <[email protected]> * docs(readme): use single README file for latest/preview version Signed-off-by: Robert Goniszewski <[email protected]> * feat(ci): add manual deployment workflow and adjust tag conditions Signed-off-by: Robert Goniszewski <[email protected]> * refactor(workflow): simplify manual-deploy GitHub Action Signed-off-by: Robert Goniszewski <[email protected]> * fix(metadata): handle multiple image URLs in mainImageUrl field Signed-off-by: Robert Goniszewski <[email protected]> * fix: auth error handling (goniszewski#144) * refactor(api): migrate Swagger UI to external documentation and enhance health endpoint Signed-off-by: Robert Goniszewski <[email protected]> * chore: release v0.4.3 --------- Signed-off-by: Robert Goniszewski <[email protected]> Co-authored-by: Prabhanjan <[email protected]>
gpoussel
changed the title
Fix creation/update of root categories
Fix issue #153: creation/update of root categories
Dec 5, 2024
goniszewski
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gpoussel great PR, thank you!
PS I had to change the target branch, but no other issues spotted :)
Quality Gate passedIssues Measures |
goniszewski
added a commit
that referenced
this pull request
Dec 9, 2024
* chore: release v0.4.1-hotfix.3 * fix(data-migration): early return if no categories have parents (#128) Signed-off-by: Robert Goniszewski <[email protected]> * Closes #130 (#131) Signed-off-by: Robert Goniszewski <[email protected]> * fix(database): use dynamic path for SQLite database file Signed-off-by: Robert Goniszewski <[email protected]> * docs(readme): use single README file for latest/preview version Signed-off-by: Robert Goniszewski <[email protected]> * feat(ci): add manual deployment workflow and adjust tag conditions Signed-off-by: Robert Goniszewski <[email protected]> * refactor(workflow): simplify manual-deploy GitHub Action Signed-off-by: Robert Goniszewski <[email protected]> * fix(metadata): handle multiple image URLs in mainImageUrl field Signed-off-by: Robert Goniszewski <[email protected]> * fix: auth error handling (#144) * refactor(api): migrate Swagger UI to external documentation and enhance health endpoint Signed-off-by: Robert Goniszewski <[email protected]> * chore: release v0.4.3 * fix(docker): resolve issue with data directory permissions (#150) * Fix issue #153: creation/update of root categories (#157) * chore: release v0.4.3 (#149) * chore: release v0.4.1-hotfix.3 * fix(data-migration): early return if no categories have parents (#128) Signed-off-by: Robert Goniszewski <[email protected]> * Closes #130 (#131) Signed-off-by: Robert Goniszewski <[email protected]> * fix(database): use dynamic path for SQLite database file Signed-off-by: Robert Goniszewski <[email protected]> * docs(readme): use single README file for latest/preview version Signed-off-by: Robert Goniszewski <[email protected]> * feat(ci): add manual deployment workflow and adjust tag conditions Signed-off-by: Robert Goniszewski <[email protected]> * refactor(workflow): simplify manual-deploy GitHub Action Signed-off-by: Robert Goniszewski <[email protected]> * fix(metadata): handle multiple image URLs in mainImageUrl field Signed-off-by: Robert Goniszewski <[email protected]> * fix: auth error handling (#144) * refactor(api): migrate Swagger UI to external documentation and enhance health endpoint Signed-off-by: Robert Goniszewski <[email protected]> * chore: release v0.4.3 --------- Signed-off-by: Robert Goniszewski <[email protected]> Co-authored-by: Prabhanjan <[email protected]> * Fix creation/update of root categories --------- Signed-off-by: Robert Goniszewski <[email protected]> Co-authored-by: Robert Goniszewski <[email protected]> Co-authored-by: Prabhanjan <[email protected]> * Fix issue #145: bookmarks without images (#156) * chore: release v0.4.3 (#149) * chore: release v0.4.1-hotfix.3 * fix(data-migration): early return if no categories have parents (#128) Signed-off-by: Robert Goniszewski <[email protected]> * Closes #130 (#131) Signed-off-by: Robert Goniszewski <[email protected]> * fix(database): use dynamic path for SQLite database file Signed-off-by: Robert Goniszewski <[email protected]> * docs(readme): use single README file for latest/preview version Signed-off-by: Robert Goniszewski <[email protected]> * feat(ci): add manual deployment workflow and adjust tag conditions Signed-off-by: Robert Goniszewski <[email protected]> * refactor(workflow): simplify manual-deploy GitHub Action Signed-off-by: Robert Goniszewski <[email protected]> * fix(metadata): handle multiple image URLs in mainImageUrl field Signed-off-by: Robert Goniszewski <[email protected]> * fix: auth error handling (#144) * refactor(api): migrate Swagger UI to external documentation and enhance health endpoint Signed-off-by: Robert Goniszewski <[email protected]> * chore: release v0.4.3 --------- Signed-off-by: Robert Goniszewski <[email protected]> Co-authored-by: Prabhanjan <[email protected]> * Fix bookmark creation/update without image --------- Signed-off-by: Robert Goniszewski <[email protected]> Co-authored-by: Robert Goniszewski <[email protected]> Co-authored-by: Prabhanjan <[email protected]> * chore: release v0.4.4 --------- Signed-off-by: Robert Goniszewski <[email protected]> Co-authored-by: Prabhanjan <[email protected]> Co-authored-by: Guillaume Poussel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #153
Unfortunately, due to rob-balfre/svelte-select#662, we cannot use the
number
type for select options, otherwise we can see "undefined"