Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #4

Merged
merged 5 commits into from
Jan 15, 2024
Merged

Update dependencies #4

merged 5 commits into from
Jan 15, 2024

Conversation

fluxxcode
Copy link
Member

@fluxxcode fluxxcode commented Dec 20, 2023

  • Updated python to 3.12.1
  • Updated prometheus-client to 0.19.0
  • Updated asterisk-ami to 0.1.7
  • Updated jsonschema to 4.20.0
  • Updated Docker image to use python:3.12.1-alpine
  • Updated Flake8 to run on ubuntu-22.04
  • Updated Flake8 to use python version 3.12.1

@fluxxcode fluxxcode changed the base branch from master to develop December 20, 2023 11:20
@fluxxcode fluxxcode changed the title Update python Update dependencies Jan 4, 2024
@fluxxcode
Copy link
Member Author

On Python version 3.12.1, Python issues the following warnings in the asterisk-ami library:

asterisk-prometheus-exporter/.venv/lib/python3.12/site-packages/asterisk/ami/client.py:52: SyntaxWarning: invalid escape sequence '\.'
  asterisk_start_regex = re.compile('^Asterisk *Call *Manager/(?P<version>([0-9]+\.)*[0-9]+)', re.IGNORECASE)
asterisk-prometheus-exporter/.venv/lib/python3.12/site-packages/asterisk/ami/response.py:7: SyntaxWarning: invalid escape sequence '\-'
  key_regex = re.compile('^[a-zA-Z0-9_\-]+$')

According to the website https://adamj.eu/tech/2022/11/04/why-does-python-deprecationwarning-invalid-escape-sequence/ this is a warning that future Python versions may change to a syntax error. However, this is a bug that needs to be fixed in the asterisk-ami library. I'll leave the PR open until the warning is fixed.

Updated asterisk-ami dependency from 0.1.6 to 0.1.7
@fluxxcode
Copy link
Member Author

The syntax warning in the asterisk-ami library was fixed with version 0.1.7.

@fluxxcode fluxxcode requested a review from denzs January 5, 2024 13:08
@fluxxcode fluxxcode added the enhancement New feature or request label Jan 8, 2024
Copy link
Member

@denzs denzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@fluxxcode fluxxcode merged commit 525b69b into develop Jan 15, 2024
4 checks passed
@fluxxcode fluxxcode deleted the feat/update_python branch January 15, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants