Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker instructions in README #10

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Conversation

fluxxcode
Copy link
Member

Updated Docker installation example to use the provided Docker image on GitHub Packages.

@fluxxcode fluxxcode requested a review from denzs December 22, 2023 08:21
@denzs
Copy link
Member

denzs commented Dec 22, 2023

I think the "running with docker" part should be placed before "installation with poetry" as most people just want to use such an exporter and only a few a interested in development details..

@fluxxcode
Copy link
Member Author

I think the "running with docker" part should be placed before "installation with poetry" as most people just want to use such an exporter and only a few a interested in development details..

I think thats a good idea. I'll adjust the order :)

Copy link
Member

@denzs denzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! ship it :)

@fluxxcode fluxxcode merged commit 23e51dc into develop Jan 4, 2024
4 checks passed
@fluxxcode fluxxcode deleted the doc/update_readme branch January 4, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants