Feature/form refactor #631
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
{{cookiecutter.repo_name}}/{{cookiecutter.repo_name}}/templates/forms/password.jinja
Outdated
Show resolved
Hide resolved
melissafelch
suggested changes
Sep 11, 2023
There was a problem hiding this comment.
Looking very nice over here! I think a couple of the updated files got missed with the patch - templates/forms/widgets/password.html is looking for incorrect macro names, and /templates/forms/select.jinja appears to be outdated (it's missing some exports referenced in /form-test/). There's a minor issue with password's missing name as well, but so far this looks ✨ great! ✨
alligatortower
force-pushed
the
feature/form_refactor
branch
from
7747144 to
a7c14eb
Compare
|
Let it be written into record -- my rebasing swallowed some of Melissa's commits and so she deserves some credit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.