-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL links with double quotes are not parsed/rendered correctly #327
Comments
Provide a minimal repro i.e. remove 99% of unnecessary stuff from the URL. Provide https://babelmark.github.io/ link (press CONVERT button to get shareable link). Provide equivalent test case by modifying https://arslexis.io/goplayground/#txO7hJ-ibeU and use |
@kjk I updated the description with a simple example Babelmark link: https://babelmark.github.io/?text=%5BSome+site%5D(https%3A%2F%2Fsomesite.com%2F%3F%22something%2520in%2520quotes%22(blah)harp) You can see that most markdown libraries render it correctly and only a few like markuru, mini-markddown and markus render it with an issue, like what I reported above Test case: https://arslexis.io/goplayground/#cpdqcJHQ0qV You can see that it outputs
which is incorrect, as it should be
|
Even shorter: Test case:
Two problems:
Having We should require a space before title start ( Not exactly a simple fix. The change would be in |
Example:
[Some site](https://somesite.com/?"something%20in%20quotes"(blah)harp)
Renders as:
Somesiteharp)
Where
Somesite
renders as a link andharp)
as textIf I replace double quotes with %22, then it renders correctly as
Somesite
link. In other words, this renders as expected:Renders as link:
Somesite
Other markdown libraries (including VS Code markdown preview) render urls with quotes correctly.
The text was updated successfully, but these errors were encountered: