Move Sanitize filter further to front of filter chain, don't sanitize Macros seperately #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary precompilation task.
… Macros seperately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #408.
I couldn't move the Sanitize filter all the way to the front since that caused the TOC to render incorrectly. But now it's in front of (i.e. executed after) the Macro filter and others, which is safer. Removed the separate sanitization step in the Macro filter.
We could still try placing the BibTeX filter behind the Sanitize filter so that gets sanitized as well.
There is a separate sanitization call in the YAML filter too, but that's unfortunately necessary because metadata gets parsed independently from the rest of the page.