Add test for zip #65
Merged
Add test for zip #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update linter config to remove warnings as project is on Go 1.19 (copyloopvar, intrange), and disable linter that forces tests to be in a separate package (testpackage)
davidnewhall
requested changes
Jun 30, 2024
zip_test.go
Outdated
| require.NoError(t, err, "creating temp directory failed") | ||
| defer os.RemoveAll(name) | ||
|
|
||
| zipTestFile := filepath.Join(name, "archive.zip") |
There was a problem hiding this comment.
You could probably build a zip instead of store one in the repo. The files_test.go file builds a directory structure. Maybe repurpose that code, and then zip the directory it makes? Just an idea.
|
I like it. Stare at it until you're happy with it. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update linter config to remove warnings as project is on Go 1.19 (copyloopvar, intrange), and disable linter that forces tests to be in a separate package (testpackage)
PS: sorry for not following on my previous PR. :-(