fix(deps): fix pnpm dependency issue #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ckfngod It looks good to me, i haven't tested but does everything run locally/build? |
|
@underfisk added lockfile. yeah, everything builds and all tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #817
Never used pnpm before but my understanding is that it's looking for the new version of a local workspace package on the registry which it can't find because it hasn't been published yet.
I believe the correct way to handle this is to update all golevelup dependencies to use the local workspace packages instead of what is on the registry as detailed in their docs (https://pnpm.io/workspaces#publishing-workspace-packages).
@WonderPanda @underfisk Let me know what you guys think.