-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initializing Rabbit Module creates random queues #667
Comments
I also encountered this issue, and it's not just the queue attribute, but also the queueOptions attribute with different names in the two configurations maybe should modify this line:
to
|
This is an attempt to fix the issue where this library doesn't pass the right arguments to setupQueue in setupQueuesWithBindings. In addition, this removes the duplicate setup that setupQueuesWithBindings was doing that setupQueue alredy does. re golevelup#667
The next version shall include the fix for this, bumping here for @WonderPanda |
nice |
Awesome, thanks for working on this! |
All the merit goes to @ttshivers ! He's doing an amazing job helping out |
Hello everyone! I had the same problem, but I used version 5.0.0 and it didn't solve the problem... |
On initializing a module with a queue specified, the library creates random queues if
createQueueIfNotExists
is on.This happens at
nestjs/packages/rabbitmq/src/amqp/connection.ts
Lines 304 to 305 in be88a40
The setupQueue method expects a subscriptionsOptions object of type
MessageHandlerOptions
but is passed in an object of typeRabbitMQQueueConfig
. This object does not have the queue propertynestjs/packages/rabbitmq/src/amqp/connection.ts
Lines 671 to 672 in be88a40
Also on a side note: should assertQueue not create a queue at
nestjs/packages/rabbitmq/src/amqp/connection.ts
Lines 304 to 305 in be88a40
createQueueIfNotExists
) in this case shouldn't matter?The text was updated successfully, but these errors were encountered: