Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get individual results instead of the accumulated ones #682

Merged
merged 4 commits into from
Sep 27, 2021
Merged

get individual results instead of the accumulated ones #682

merged 4 commits into from
Sep 27, 2021

Conversation

shadeofblue
Copy link
Contributor

@shadeofblue shadeofblue commented Sep 27, 2021 •
edited
Loading

sort of closes #676 ;p

@shadeofblue shadeofblue requested review from a team and kmazurek September 27, 2021 12:47
kmazurek
kmazurek approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@kmazurek kmazurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're at it I think docstrings and readme should also be updated to this usage convention, more specifically: Golem#execute_tasks, Service#run and README.md.

@shadeofblue shadeofblue merged commit b649a89 into master Sep 27, 2021
@shadeofblue shadeofblue deleted the individual-results branch September 27, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johny-b johny-b johny-b approved these changes

@kmazurek kmazurek kmazurek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

issues encountered while trying to use the partial results capture feature
3 participants
@shadeofblue @kmazurek @johny-b