GOTH - Power outage test #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maaktweluit
force-pushed
the
mwu/goth-power-outage
branch
2 times, most recently
from
019109a to
e19240a
Compare
maaktweluit
force-pushed
the
mwu/goth-power-outage
branch
from
e19240a to
326f23e
Compare
nieznanysprawiciel
approved these changes
Sep 26, 2021
kmazurek
approved these changes
Sep 27, 2021
|
|
||
| logger.debug("Stopping provider 1") | ||
| await provider_1.stop() | ||
| provider_1.container.stop() |
There was a problem hiding this comment.
Since goth version 0.7.2 (latest patch release) Container.stop gets called as part of Probe.stop, so this line is no longer necessary. :)
There was a problem hiding this comment.
awesome, goth keeps getting better :D
| logger.info("All tasks computed, waiting for Golem shutdown") | ||
|
|
||
| await cmd_monitor.wait_for_pattern(".*Unpaid agreements: .*") | ||
| logger.info("Expected 1 unpaid agreement") |
There was a problem hiding this comment.
Suggested change
| logger.info("Expected 1 unpaid agreement") | |
| logger.info("Found expected unpaid agreement") |
kmazurek
reviewed
Sep 27, 2021
| await provider_1.stop() | ||
| provider_1.container.stop() | ||
| logger.info("Provider 1 stopped.") | ||
| provider_1.container.restart() |
There was a problem hiding this comment.
And this shouldn't be necessary with goth version 0.7.3. :D
There was a problem hiding this comment.
great! can update this in a cleanup PR if needed :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: golemfactory/yagna#1508
Add a power outage test where one provider is stopped after receiving a task data.
The test expects all tasks to be finished but not all invoices to be paid.
Possible improvements: