Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add vpn capability properties #658

Merged
merged 6 commits into from
Sep 16, 2021
Merged

add vpn capability properties #658

merged 6 commits into from
Sep 16, 2021

Conversation

shadeofblue
Copy link
Contributor

  • support for list constraints

@shadeofblue
add vpn capability properties
1beb0c7 
+ support for list constraints
@shadeofblue shadeofblue requested review from a team, johny-b and kmazurek September 15, 2021 13:53
johny-b
johny-b reviewed Sep 15, 2021
View reviewed changes
Copy link
Contributor

@johny-b johny-b left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, first a disclaimer. I don't have a feeling I understand those "capabilities", "props" etc things really well. If my comments make no sense, then I probably need some explanation what's going on.

Other than that, this looks good, just some minor things.

yapapi/payload/vm.py
if sys.version_info > (3, 8):
from typing import Literal
else:
from typing_extensions import Literal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both Final and Literal are in typing since 3.8.
I have no opinion on whether we should always import them from _extensions or base import on sys.version_info, but I'm sure we should have them together.

yapapi/payload/vm.py Show resolved Hide resolved
yapapi/props/base.py Outdated Show resolved Hide resolved
@johny-b johny-b self-requested a review September 16, 2021 09:54
johny-b
johny-b approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@johny-b johny-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇹🇭

@shadeofblue shadeofblue merged commit 81f95ae into master Sep 16, 2021
@shadeofblue shadeofblue mentioned this pull request Sep 16, 2021
Closed
@shadeofblue shadeofblue deleted the blue/vpn-caps branch September 16, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johny-b johny-b johny-b approved these changes

@kmazurek kmazurek Awaiting requested review from kmazurek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shadeofblue @johny-b