Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest-rerunfailures in goth tests #643

Merged
merged 5 commits into from
Sep 10, 2021
Merged

Conversation

johny-b
Copy link
Contributor

@johny-b johny-b commented Sep 9, 2021

Things I checked:

  • random exceptions like ZeroDivisionError don't cause reruns
  • failing await wait_for_event(...) causes reruns

--> this looks like the thing we need.

Unfortunately, a not-very-pretty hack was necessary to make this work. I think that this is acceptable, but I'm curious what others think.

Other options and general research summary are in golemfactory/goth#545

@johny-b johny-b marked this pull request as ready for review September 10, 2021 14:52
@johny-b johny-b requested a review from a team September 10, 2021 14:52
@johny-b johny-b merged commit 4b23a8c into master Sep 10, 2021
@shadeofblue shadeofblue deleted the johny-b/goth-545-rerun-failed branch September 16, 2021 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants