Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script.results - 2 lines less in process_batches! #641

Closed
wants to merge 2 commits into from
Closed

Script.results - 2 lines less in process_batches! #641

wants to merge 2 commits into from

Conversation

johny-b
Copy link
Contributor

@johny-b johny-b commented Sep 9, 2021

No description provided.

@johny-b johny-b requested review from kmazurek and a team September 9, 2021 11:46
@kmazurek kmazurek changed the base branch from km/context-script-decouple to master September 9, 2021 14:41
@johny-b
Copy link
Contributor Author

johny-b commented Sep 9, 2021

Wow actually this mypy thing is useful.
This PR is wrong because it removes all results that are not CommandExecuted.

@johny-b johny-b closed this Sep 9, 2021
@johny-b johny-b deleted the johny-b/result_in_process_batches branch September 21, 2021 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmazurek kmazurek Awaiting requested review from kmazurek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johny-b @kmazurek