Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Johny b/585 api reference sphinx #622

Merged
merged 34 commits into from
Sep 17, 2021
Merged

Conversation

johny-b
Copy link
Contributor

@johny-b johny-b commented Sep 1, 2021

Rendered version:
https://yapapi.readthedocs.io/en/johny-b-readthedocs-test/api.html
(It's rendered from another branch because I had some troubles with refreshing readthedocs, but the code is the same. Readthedocs integration should be improved in #625 )

There are a lot of lines in the diff, but most of changes are links inside the docs, so e.g. `Golem` -> :class:`~yapapi.Golem`.

There were few bigger changes:

  • SummaryLogger - removed references to the Executor class
  • Script - moved param documentation to :params: section @zakaprov

(Reminder: we're not aiming for a perfect version, just a good enough one).

johny-b and others added 30 commits August 20, 2021 17:19
Run: `poetry run poe sphinx-markdown`
Result: `build/markdown/index.md`
Now we have 2 files and the main (the one we want to send people to)
is `api.html`, not `index.html`.
@johny-b johny-b marked this pull request as ready for review September 17, 2021 09:11
@johny-b johny-b requested a review from a team September 17, 2021 09:11
Copy link
Contributor

@shadeofblue shadeofblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good_job_pony

@johny-b johny-b merged commit 12e2d9a into master Sep 17, 2021
@johny-b johny-b deleted the johny-b/585-api-reference-sphinx branch September 21, 2021 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants