-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B0.6 to master #607
Merged
Merged
B0.6 to master #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ovider (#543) * Delete unused temp files and close unpublished URLs in GftpStorageProvider * Add unit tests for GftpStorageProvider * Ensure newly created temp files are closed before being used If we keep a file open we won't be able to delete it on Windows * Address code review suggestions Co-authored-by: Kuba Mazurek <[email protected]>
* Read env var to determine if GftpProvider shoud call `gftp close` * Add info on YAPAPI_USE_GFTP_CLOSE env var to README.md
* Implement re-tries for ApiExceptions caused by GSB Errors * Endpoint -> endpoint * Apply fixes after code review * Fixes after code review: part II * debug -> warning * Improve logs when activity is prematurely terminated on the provider * Formatting * Raise BatchError when an activity is terminated by the provider * Add unit tests for PollingBatch behavior when GSB errors occur Co-authored-by: filipgolem <[email protected]> Co-authored-by: Filip <[email protected]>
kmazurek
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.