Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B0.6 to master #607

Merged
merged 12 commits into from
Aug 24, 2021
Merged

B0.6 to master #607

merged 12 commits into from
Aug 24, 2021

Conversation

azawlocki
Copy link
Contributor

No description provided.

azawlocki and others added 10 commits August 3, 2021 17:04
…ovider (#543)

* Delete unused temp files and close unpublished URLs in GftpStorageProvider
* Add unit tests for GftpStorageProvider
* Ensure newly created temp files are closed before being used
  If we keep a file open we won't be able to delete it on Windows
* Address code review suggestions
Co-authored-by: Kuba Mazurek <[email protected]>
* Read env var to determine if GftpProvider shoud call `gftp close`

* Add info on YAPAPI_USE_GFTP_CLOSE env var to README.md
)

* Check gftp version to determine if `gftp close URL` should be used

* Add `# type: ignore` to `import semantic_version`

* Add unit test for various env var/gftp version combinations
* Implement re-tries for ApiExceptions caused by GSB Errors

* Endpoint -> endpoint

* Apply fixes after code review

* Fixes after code review: part II

* debug -> warning

* Improve logs when activity is prematurely terminated on the provider

* Formatting

* Raise BatchError when an activity is terminated by the provider

* Add unit tests for PollingBatch behavior when GSB errors occur

Co-authored-by: filipgolem <[email protected]>
Co-authored-by: Filip <[email protected]>
@azawlocki azawlocki requested a review from a team August 24, 2021 10:13
@azawlocki azawlocki merged commit b5d92be into master Aug 24, 2021
@azawlocki azawlocki deleted the b0.6-to-master branch August 24, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants