Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom usage counter support #594

Merged
merged 2 commits into from
Aug 18, 2021
Merged

Custom usage counter support #594

merged 2 commits into from
Aug 18, 2021

Conversation

mfranciszkiewicz
Copy link
Contributor

@mfranciszkiewicz mfranciszkiewicz commented Aug 16, 2021 •
edited
Loading

This PR allows for handling offers with custom usage counters (e.g. defined by services built with ya-runtime-sdk)

  • usage counters are no longer constrained by Counter enum
  • rework market strategies to use counter property names instead of the Counter enum
  • unify construction of dummy and linear market strategy objects

@mfranciszkiewicz mfranciszkiewicz requested a review from a team August 16, 2021 12:18
@shadeofblue shadeofblue self-assigned this Aug 17, 2021
shadeofblue
shadeofblue approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@shadeofblue shadeofblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay @mfranciszkiewicz I think we can merge this one as is and decide whether we want to get rid of the enum completely later...

@shadeofblue shadeofblue merged commit a23f1e1 into master Aug 18, 2021
@shadeofblue shadeofblue deleted the mf/master/custom-counters branch August 18, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipgolem filipgolem filipgolem approved these changes

@shadeofblue shadeofblue shadeofblue approved these changes

Assignees

@shadeofblue shadeofblue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfranciszkiewicz @shadeofblue @filipgolem