Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge b0.6 to master #572

Merged
merged 4 commits into from
Aug 6, 2021
Merged

Merge b0.6 to master #572

merged 4 commits into from
Aug 6, 2021

Conversation

azawlocki
Copy link
Contributor

No description provided.

…ovider (#543)

* Delete unused temp files and close unpublished URLs in GftpStorageProvider
* Add unit tests for GftpStorageProvider
* Ensure newly created temp files are closed before being used
  If we keep a file open we won't be able to delete it on Windows
* Address code review suggestions
Co-authored-by: Kuba Mazurek <[email protected]>
@azawlocki azawlocki requested review from a team and kmazurek August 3, 2021 15:27
kmazurek and others added 3 commits August 5, 2021 14:08
* Read env var to determine if GftpProvider shoud call `gftp close`

* Add info on YAPAPI_USE_GFTP_CLOSE env var to README.md
@azawlocki azawlocki self-assigned this Aug 6, 2021
@azawlocki azawlocki requested a review from filipgolem August 6, 2021 12:23
@azawlocki azawlocki merged commit a629329 into master Aug 6, 2021
@shadeofblue shadeofblue deleted the az/b0.6-to-master branch September 13, 2021 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants