Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't spawn another instance if one instance stops due to a signal #547

Merged
merged 2 commits into from
Jul 15, 2021
Merged

Don't spawn another instance if one instance stops due to a signal #547

merged 2 commits into from
Jul 15, 2021

Conversation

azawlocki
Copy link
Contributor

Resolves #544

Changes in this PR

  • Before spawning an instance in place of another instance stopped in starting state, check if that instance was stopped due to an error and not due to a STOP signal.
  • Extend the integration test for re-spawning instances to check that a cluster does not automatically spawn new instances after Cluster.stop() is called.

@azawlocki azawlocki requested review from a team, filipgolem and shadeofblue July 14, 2021 20:07
@azawlocki azawlocki merged commit 56cc368 into b0.6 Jul 15, 2021
@azawlocki azawlocki deleted the az/dont-respawn-after-stop branch July 15, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipgolem filipgolem filipgolem approved these changes

@shadeofblue shadeofblue Awaiting requested review from shadeofblue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azawlocki @filipgolem