Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to specify full image URLs #537

Merged
merged 4 commits into from
Jul 8, 2021
Merged

Allow to specify full image URLs #537

merged 4 commits into from
Jul 8, 2021

Conversation

mfranciszkiewicz
Copy link
Contributor

Resolves #389

@mfranciszkiewicz mfranciszkiewicz requested review from azawlocki, shadeofblue and a team July 7, 2021 12:49
@shadeofblue
Copy link
Contributor

@mfranciszkiewicz is this intentional for this code to go into the b0.6 branch?

@mfranciszkiewicz mfranciszkiewicz changed the base branch from b0.6 to master July 7, 2021 14:31
@mfranciszkiewicz
Copy link
Contributor Author

@mfranciszkiewicz is this intentional for this code to go into the b0.6 branch?

Not necessarily, no.

azawlocki
azawlocki approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@azawlocki azawlocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mfranciszkiewicz mfranciszkiewicz merged commit 7139ca7 into master Jul 8, 2021
@mfranciszkiewicz mfranciszkiewicz deleted the mf/image-url branch July 8, 2021 20:07
@mfranciszkiewicz mfranciszkiewicz mentioned this pull request Sep 1, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadeofblue shadeofblue shadeofblue approved these changes

@azawlocki azawlocki azawlocki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to specify full image URLs
3 participants
@mfranciszkiewicz @shadeofblue @azawlocki