Usage reporting tweaks #536
Conversation
| parser.add_argument("--num-instances", type=int, default=1, help="The number of instances of the service to spawn") | ||
| parser.add_argument("--show-usage", action="store_true", help="Show usage and cost of each instance while running.") |
| @@ -39,9 +39,10 @@ class SimpleService(Service): | |||
| SIMPLE_SERVICE = "/golem/run/simple_service.py" | |||
| SIMPLE_SERVICE_CTL = "/golem/run/simulate_observations_ctl.py" | |||
|
|
|||
| def __init__(self, *args, instance_name, **kwargs): | |||
| def __init__(self, *args, instance_name, show_usage: bool = False, **kwargs): | |||
There was a problem hiding this comment.
I'd either specify types for both instance_name and show_usage, or for neither of them.
There was a problem hiding this comment.
I mean, here, done ;)
shadeofblue
changed the title
| from dataclasses import dataclass, field | ||
| from datetime import timedelta, datetime |
There was a problem hiding this comment.
These should go before import enum
yapapi/ctx.py
Outdated
| async def get_usage(self): | ||
| async def get_raw_usage(self) -> yaa_ActivityUsage: | ||
| """Get the raw usage vector for the activity bound to this work context. | ||
| The value comes directly from the low level API and is not interpreted in any way.""" |
There was a problem hiding this comment.
For a multi-line docstring, there should be a blank line after the first (summary) line, see https://www.python.org/dev/peps/pep-0257/#multi-line-docstrings.
Also I think the prevailing convention in yapapi docstrings is to put the closing """ on a new line in multi-line docstrings.
yapapi/ctx.py
Outdated
| """Get the state activity bound to this work context. | ||
| The value comes directly from the low level API and is not interpreted in any way.""" |
There was a problem hiding this comment.
See my remark above about multi-line docstring formatting.
yapapi/utils.py
Outdated
| @@ -2,6 +2,7 @@ | |||
| import asyncio | |||
| import logging | |||
| from typing import AsyncContextManager, Callable, Optional | |||
| from datetime import datetime, timezone, tzinfo | |||
There was a problem hiding this comment.
Please keep imports sorted according to alphabetic ordering of module names
let's just add a linter to our test runs? ... maybe as a non-required step? ;)... |
Let's, we have an issue for that: #334 |
No description provided.