Handle errors raised in batch.prepare() in process_batches() #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azawlocki
force-pushed
the
az/handle-batch-prepare-errors
branch
from
6490723 to
debc6a0
Compare
shadeofblue
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain errors can be raised in a call to
batch.prepare(), for example errors originating inyapapi'sgftpstorage driver.Such errors should be caught in
Golem.process_batches()and thrown into a command generator, especially in Services API (a command generator in this case isCluster._run_instance()). Otherwise, a service instance would become detached from the handler function and stuck in the state in which the error occurred -- this happens in issue #519.