Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix join_str_constraints #524

Merged
merged 3 commits into from
Jul 6, 2021
Merged

Fix join_str_constraints #524

merged 3 commits into from
Jul 6, 2021

Conversation

filipgolem
Copy link
Contributor

No description provided.

@filipgolem filipgolem requested review from a team, azawlocki and shadeofblue July 5, 2021 21:34
azawlocki
azawlocki previously requested changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@azawlocki azawlocki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unit tests in yapapi/tests/props/test_base.py fail for this change. They probably need to be fixed.

@azawlocki azawlocki force-pushed the fix-join-str-constraints branch from d571bdd to a99e756 Compare July 6, 2021 08:09
@filipgolem filipgolem changed the base branch from master to b0.6 July 6, 2021 08:51
@filipgolem filipgolem changed the base branch from b0.6 to master July 6, 2021 08:51
@filipgolem filipgolem merged commit f57d419 into master Jul 6, 2021
@filipgolem filipgolem deleted the fix-join-str-constraints branch July 6, 2021 08:53
filipgolem added a commit that referenced this pull request Jul 6, 2021
@filipgolem @azawlocki
Fix join_str_constraints (#524)
bdd22c4 
Co-authored-by: azawlocki <[email protected]>
shadeofblue added a commit that referenced this pull request Jul 6, 2021
@shadeofblue
Merge pull request #525 from golemfactory/b0.6-fix-constraints
e877026 
Fix join_str_constraints (#524)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadeofblue shadeofblue shadeofblue approved these changes

@azawlocki azawlocki azawlocki left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filipgolem @azawlocki @shadeofblue