Close async generators created by Executor on Golem shutdown #482
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #481
The following scenario leads to a deadlock:
On shutdown,
Golem
is waiting for all registeredJob
s to be marked as finished. However, aJob
created byExecutor.submit()
(called fromexecute_tasks()
) is marked as finished only after all tasks are retrieved from the associated async generator (here:completed
).To fix this, in this PR we register each async generator created by
Executor.submit()
in aGolem
instance used by theExecutor
. When the instance shuts down, it callsaclose()
on all registered generators before waiting for the registered jobs.