Prevent double file open in yacat example

examples/yacat/yacat.py

@@ -3,9 +3,10 @@
 import asyncio
 from datetime import datetime, timedelta
 import math
+import os
 from pathlib import Path
 import sys
-from tempfile import NamedTemporaryFile
+import tempfile
 from typing import AsyncIterable, List, Optional
 
 from yapapi import Golem, NoPaymentAccountError, Task, WorkContext, windows_event_loop_fix
@@ -104,15 +105,16 @@ async def perform_mask_attack(ctx: WorkContext, tasks: AsyncIterable[Task]):
         limit = skip + args.chunk_size
         worker_output_path = f"/golem/output/hashcat_{skip}.potfile"
 
-        ctx.run(f"/bin/sh", "-c", _make_attack_command(skip, limit, worker_output_path))
-        output_file = NamedTemporaryFile()
-        ctx.download_file(worker_output_path, output_file.name)
+        ctx.run("/bin/sh", "-c", _make_attack_command(skip, limit, worker_output_path))
+        output_file = Path(tempfile.gettempdir()) / os.urandom(16).hex()
+        ctx.download_file(worker_output_path, output_file)
 
         yield ctx.commit(timeout=MASK_ATTACK_TIMEOUT)
 
-        result = output_file.file.readline()
-        task.accept_result(result)
-        output_file.close()
+        with output_file.open() as f:
+            result = f.readline()
+            task.accept_result(result)
+        os.remove(str(output_file))
 
 
 def _make_attack_command(skip: int, limit: int, output_path: str) -> str:

yapapi/ctx.py

@@ -6,7 +6,7 @@
 from os import PathLike
 from functools import partial
 from pathlib import Path
-from typing import Callable, Iterable, Optional, Dict, List, Tuple, Union, Any, Awaitable
+from typing import BinaryIO, Callable, Iterable, Optional, Dict, List, Tuple, Union, Any, Awaitable
 
 from yapapi.events import DownloadStarted, DownloadFinished
 from yapapi.props import NodeInfo
@@ -189,7 +189,7 @@ def __init__(
         self,
         storage: StorageProvider,
         src_path: str,
-        dst_path: str,
+        dst_path: Union[PathLike, BinaryIO],
         emitter: Optional[Callable[[StorageEvent], None]] = None,
     ):
         super().__init__(storage, src_path, emitter)
@@ -385,7 +385,7 @@ def run(
         self.__prepare()
         self._pending_steps.append(_Run(cmd, *args, env=env, stdout=stdout, stderr=stderr))
 
-    def download_file(self, src_path: str, dst_path: str):
+    def download_file(self, src_path: str, dst_path: Union[PathLike, BinaryIO]):
         """Schedule downloading remote file from the provider.
 
         :param src_path: remote (provider) path

yapapi/storage/__init__.py

@@ -7,7 +7,7 @@
 import pathlib
 import io
 from os import PathLike
-from typing import AsyncIterator, NamedTuple, Union, Optional
+from typing import AsyncIterator, BinaryIO, NamedTuple, Union, Optional
 import asyncio
 import aiohttp
 
@@ -65,9 +65,13 @@ async def download_bytes(self, limit: int = DOWNLOAD_BYTES_LIMIT_DEFAULT):
 
         return output
 
-    async def download_file(self, destination_file: PathLike):
+    async def download_file(self, destination_file: Union[PathLike, BinaryIO]):
         content = await self.download_stream()
-        with open(destination_file, "wb") as f:
+
+        if isinstance(destination_file, PathLike):
+            destination_file = open(destination_file, "wb")
+
+        with destination_file as f:
             async for chunk in content.stream:
                 f.write(chunk)