Always cancel process_invoices_job when shutting down Golem #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azawlocki
commented
Jun 10, 2021
| logger.debug("process_invoices_job cancelled") | ||
| if self._agreements_to_pay: | ||
| logger.warning("Unpaid agreements: %s", self._agreements_to_pay) | ||
|
|
||
| self._process_invoices_job.cancel() |
There was a problem hiding this comment.
this one line was misplaced, it should always be executed
azawlocki
commented
Jun 10, 2021
| if self._agreements_to_pay: | ||
| logger.warning("Unpaid agreements: %s", self._agreements_to_pay) | ||
|
|
||
| await asyncio.gather(*[job.finished.wait() for job in self._jobs]) |
There was a problem hiding this comment.
this line is a duplicate, we already do this at the beginning of this method
shadeofblue
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #442