Wait for instance tasks before shutting down Cluster #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azawlocki
force-pushed
the
az/wait-for-instance-tasks
branch
from
edfd63e to
378449b
Compare
shadeofblue
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #422
#422 is caused by asyncio tasks that run
Cluster.spawn_instance()being left running in the background when theirClusterandGoleminstances shut down. In particular, part ofGolemshutdown process is closing API clients which may still be used by those instance tasks (to destroy an activity and terminate an agreement, etc.).This PR modifies
Cluster.__aexit__()to wait until those tasks terminate (and cancel them, if they don't terminate within 10s).Also included is a fix for the "ugly traceback" part of golemfactory/yagna-triage#119: when shutting down Golem, we cancel the job that waits for incoming invoices after 30s.