Multiplexing command batches and control signals #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadeofblue
reviewed
May 28, 2021
| # Repeatedly wait on one of `(batch_task, signal_task)` to finish. | ||
| # If it's the first one, retrieve a batch from its result and handle it. | ||
| # If it's the second -- retrieve and handle a signal. | ||
| # Any finished task is replaced with a new one, so there are always two. |
shadeofblue
reviewed
May 28, 2021
| if batch_task is None: | ||
| batch_task = loop.create_task(handler.__anext__()) | ||
| if signal_task is None: | ||
| signal_task = loop.create_task(instance.control_queue.get()) |
There was a problem hiding this comment.
maybe we should remove ServiceInstance.get_control_signal then ?
There was a problem hiding this comment.
removed in 648c114
shadeofblue
reviewed
May 28, 2021
yapapi/executor/services.py
Outdated
Comment on lines
356
to
362
| if batch_task: | ||
| batch_task.cancel() | ||
| await batch_task | ||
| if signal_task: | ||
| signal_task.cancel() | ||
| await signal_task | ||
|
|
There was a problem hiding this comment.
I think this should go before the above logger message, and maybe a new .debug one should be added above
shadeofblue
suggested changes
May 28, 2021
shadeofblue
reviewed
May 28, 2021
| @@ -299,7 +290,7 @@ async def _run_instance(self, ctx: WorkContext): | |||
| instance = ServiceInstance(service=self._service_class(self, ctx)) | |||
| self.__instances.append(instance) | |||
|
|
|||
| logger.info(f"{instance.service} commissioned") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements processing of a stream of command batches generated by a service state handler, interleaved with a stream control signals.
Resolves #396