Fix passing command errors from the engine to worker functions #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azawlocki
commented
May 21, 2021
Comment on lines
+538
to
+539
| item = await command_generator.asend(future_results) | ||
|
|
There was a problem hiding this comment.
We shouldn't handle errors raised in command_generator.asend() as they include exceptions thrown in the worker function.
azawlocki
commented
May 24, 2021
Comment on lines
+129
to
+135
| while True: | ||
| if self._rescheduled_items: | ||
| return True | ||
| try: | ||
| return await asyncio.wait_for(self.has_new_items(), 1.0) | ||
| except asyncio.TimeoutError: | ||
| pass |
There was a problem hiding this comment.
Instead of waiting indefinitely on potentialy blocking await self.has_new_items(), periodically check if there are self._rescheduled_items.
azawlocki
force-pushed
the
az/process-batches-error-handling
branch
from
12a6fc2 to
9cbee0f
Compare
shadeofblue
approved these changes
May 24, 2021
@shadeofblue Yes, in the sense that if you pass a non-async iterator that blocks for a long time before yielding a task to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #393
Contains fixes for two separate issues reported by A&C Team:
SmartQueue(commit 9cbee0f).