some comments to the SmartQueue #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azawlocki
suggested changes
Apr 30, 2021
yapapi/executor/_smartq.py
Outdated
| @@ -27,7 +27,16 @@ | |||
| Item = TypeVar("Item") | |||
|
|
|||
|
|
|||
| class Handle(Generic[Item], object): | |||
| class Handle( | |||
| Generic[Item], object | |||
There was a problem hiding this comment.
While we're here, let's remove this object, so Python2-ic
yapapi/executor/_smartq.py
Outdated
| class Handle(Generic[Item], object): | ||
| class Handle( | ||
| Generic[Item], object | ||
| ): # Handling? QueueItem? ConsumedItem? ConsumerItem? ConsumerBinding? |
There was a problem hiding this comment.
I've got used to Handle, it's not that bad. Either way, let's not forget to remove this comment.
yapapi/executor/_smartq.py
Outdated
| def __init__(self, items: Iterable[Item]): | ||
| """ | ||
| :param items: the items to be iterated over | ||
| :param retry_cnt: |
There was a problem hiding this comment.
If we drop this argument from __init__() (I understand that's because it's unused) then let's not add a docstring for it.
yapapi/executor/_smartq.py
Outdated
| @@ -126,13 +143,15 @@ async def mark_done(self, handle: Handle[Item]) -> None: | |||
| ) | |||
|
|
|||
| async def reschedule(self, handle: Handle[Item]) -> None: | |||
| """free the item for reassignment to another consumer""" | |||
There was a problem hiding this comment.
I we ever run yapapi code through flake8 it will complain about method docstrings not starting with a capital letter and not ending with a full stop.
yapapi/executor/_smartq.py
Outdated
| @@ -178,6 +203,7 @@ def __exit__( | |||
|
|
|||
| @property | |||
| def last_item(self) -> Optional[Item]: | |||
| """shouldn't it be called `current_item` ?""" | |||
There was a problem hiding this comment.
Agreed, I'd call it current_item as well.
|
@azawlocki addressed your comments, pls re-review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.