Add Api Configuration

[lucekdudek]

• add api_config pydoc
• improve deprecate comments
• move deafault values from all over the code to Api Config class
• add tests for ApiConfig

[shadeofblue]

as previously discussed, this is a good direction but please see my comments,

especially about separation of subnet-tag and payment variables from the ApiConfig ... they don't have too much in common and should not be put in the same container...

most importantly neither the subnet, nor the payment parameters are required to instantiate any of the APIs

[johny-b]

Hmm, sorry if this is OT, but.

Will the ApiConfig work separate from all of the other yapapi stuff? E.g. can I do in my (otherwise non-yapapi) code do from yapapi.config import ApiConfig and use it?

If yes, that would be nice :)

[lucekdudek]

It was not intended but yes.

IDK if you would want to add yapapi dependency just to use a dataclass 😅

[johny-b]

Well, maybe for development purposes at least?
Also, that might not be the only imported thing:

(gc) jbetley:~/golem-core-python {jb/yacat-v2} $ grep -rIh 'from yapapi' golem_core/
from yapapi.payload import Payload as YapapiPayload, vm
from yapapi import rest
from yapapi.engine import DEFAULT_DRIVER, DEFAULT_NETWORK, DEFAULT_SUBNET
from yapapi.props.builder import DemandBuilder
from yapapi import props
from yapapi.storage import Destination, Source
from yapapi.storage.gftp import GftpProvider
from yapapi.engine import NoPaymentAccountError
from yapapi.log import _YagnaDatetimeFormatter
from yapapi.engine import DEFAULT_NETWORK, DEFAULT_DRIVER, DEFAULT_SUBNET
from yapapi.props.base import constraint
from yapapi.props import inf

:)

[shadeofblue]

lgtm :)

btw, please add budget to GolemFactory so that it doesn't need to be provided in each case...