Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to start again a Golem that was stopped #606

Closed
johny-b opened this issue Aug 23, 2021 · 0 comments · Fixed by #644
Closed

Allow to start again a Golem that was stopped #606

johny-b opened this issue Aug 23, 2021 · 0 comments · Fixed by #644
Assignees
@johny-b

Comments

@johny-b
Copy link
Contributor

johny-b commented Aug 23, 2021 •
edited
Loading

Golem.start()/Golem.stop() are implemented in #561.
Currently

golem = Golem(...)
await golem.start()
...
await golem.stop()
await golem.start()

raises some exceptions, and it shouldn't.

After #612 is done it might only require a new Golem._engine, so this might be resolved in #561 .
@johny-b johny-b mentioned this issue Aug 23, 2021
Closed
@johny-b johny-b self-assigned this Aug 23, 2021
johny-b added a commit that referenced this issue Aug 27, 2021
@johny-b
starting/stopping state refactor
0829514 
Changes:
* all logic related to explicit calls to `start()` and `stop()`
  is implemented on the Golem object
* calling multiple `start()` concurrently is harmless
* restarting a Golem is explicitly forbidden (to be fixed in #606)
@johny-b johny-b mentioned this issue Sep 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johny-b johny-b

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Golem.start() and Golem.stop() golemfactory/yapapi
1 participant
@johny-b