Skip to content

Commit

Permalink
Use command_index when calling get_exec_batch_results (#548)
Browse files Browse the repository at this point in the history
* Use command_index when calling get_exec_batch_results
* Increase timeouts in the blender integration test
* Increase timeouts in the yacat integration test

Co-authored-by: azawlocki <[email protected]>
  • Loading branch information
filipgolem and azawlocki authored Jul 19, 2021
1 parent 92ceb43 commit 9510f6f
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 6 deletions.
4 changes: 2 additions & 2 deletions tests/goth_tests/test_run_blender.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,9 @@ async def test_run_blender(
await all_sent.wait_for_result(timeout=120)
logger.info("All tasks sent")

await all_computed.wait_for_result(timeout=30)
await all_computed.wait_for_result(timeout=120)
logger.info("All tasks computed, waiting for Executor shutdown")

await cmd_monitor.wait_for_pattern(".*Executor has shut down", timeout=120)
await cmd_monitor.wait_for_pattern(".*Executor has shut down", timeout=180)

logger.info("Requestor script finished")
6 changes: 3 additions & 3 deletions tests/goth_tests/test_run_yacat.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,13 @@ async def test_run_yacat(
)
logger.info("Keyspace found")

await all_sent.wait_for_result(timeout=30)
await all_sent.wait_for_result(timeout=60)
logger.info("All tasks sent")

await all_computed.wait_for_result(timeout=60)
await all_computed.wait_for_result(timeout=120)
logger.info("All tasks computed")

await cmd_monitor.wait_for_pattern(".*Password found: yo", timeout=10)
await cmd_monitor.wait_for_pattern(".*Password found: yo", timeout=60)
logger.info("Password found, waiting for Executor shutdown")

await cmd_monitor.wait_for_pattern(".*Executor has shut down", timeout=120)
Expand Down
6 changes: 5 additions & 1 deletion yapapi/rest/activity.py
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,11 @@ async def __aiter__(self) -> AsyncIterator[events.CommandEventContext]:
raise BatchTimeoutError()
try:
results: List[yaa.ExeScriptCommandResult] = await self._api.get_exec_batch_results(
self._activity_id, self._batch_id, _request_timeout=min(timeout, 5)
self._activity_id,
self._batch_id,
command_index=last_idx,
timeout=min(timeout, 5),
_request_timeout=min(timeout, 5) + 1,
)
except asyncio.TimeoutError:
continue
Expand Down

0 comments on commit 9510f6f

Please sign in to comment.