Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scope for config overrides in goth tests #1278

Merged
merged 3 commits into from
Apr 29, 2021
Merged

Fix scope for config overrides in goth tests #1278

merged 3 commits into from
Apr 29, 2021

Conversation

kmazurek
Copy link
Contributor

@kmazurek kmazurek self-assigned this Apr 27, 2021
@kmazurek kmazurek requested a review from azawlocki April 27, 2021 10:44
azawlocki
azawlocki previously approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@azawlocki azawlocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (although making config_overrides a fixture with a "function" scope would probably work as well and require only changing in a single line of code).

@kmazurek
Copy link
Contributor Author

@azawlocki Agreed, I'm going to update this PR once goth version 0.2.4 is released (so that integration tests here use a stable release version). The relevant PR in goth is here: golemfactory/goth#500

@kmazurek kmazurek force-pushed the km/goth-config-overrides branch from b3fa5e3 to 672608d Compare April 28, 2021 18:52
@kmazurek kmazurek changed the title Make config overrides a tuple Fix scope for config overrides in goth tests Apr 29, 2021
@kmazurek kmazurek enabled auto-merge April 29, 2021 08:33
azawlocki
azawlocki approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@azawlocki azawlocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kmazurek kmazurek merged commit db809b3 into master Apr 29, 2021
@kmazurek kmazurek deleted the km/goth-config-overrides branch April 29, 2021 08:40
maaktweluit pushed a commit that referenced this pull request May 24, 2021
@kmazurek @maaktweluit
Merge pull request #1278 from golemfactory/km/goth-config-overrides
60ed666 
Fix scope for config overrides in goth tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azawlocki azawlocki azawlocki approved these changes

Assignees

@kmazurek kmazurek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom build options leaking through test cases
2 participants
@kmazurek @azawlocki