Add hybrid net support to goth #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maaktweluit
commented
Oct 27, 2021
•
maaktweluit
commented
- Allow separate configuration of docker compose file
- Add new env for hybrid net
- Add docker compose for the new hybrid net setup
maaktweluit
force-pushed
the
mwu/test-hybrid-net
branch
3 times, most recently
from
86e67fe to
fee249c
Compare
maaktweluit
force-pushed
the
mwu/test-hybrid-net
branch
from
d0ad768 to
1272095
Compare
kmazurek
approved these changes
Nov 16, 2021
| @@ -5,6 +5,7 @@ | |||
|
|
|||
| docker-compose: | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
| # Path to compose file to be used, relative to `docker-dir` |
goth/address.py
Outdated
| @@ -67,7 +67,7 @@ def _with_default(self, mapping: Mapping[str, object]): | |||
|
|
|||
| ROUTER_HOST = "router" | |||
| ROUTER_PORT = 7477 | |||
| ROUTER_PROTOCOL = "tcp" | |||
| ROUTER_PROTOCOL = "udp" | |||
There was a problem hiding this comment.
Is this / should this be backward-compatible with ya-sb-router?
There was a problem hiding this comment.
its not used :( we should remove those variables for now...
reverted the change to keep it backwards compatible and cleaner
maaktweluit
force-pushed
the
mwu/test-hybrid-net
branch
from
5cc37db to
8a01f63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.