Explicitly disconnect yagna containers before stopping Docker network #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmazurek
approved these changes
Aug 27, 2021
goth/runner/container/compose.py
Outdated
| """Stop the running compose network, removing its containers. | ||
|
|
||
| Before the network is stopped, all yagna containers need to be disconnected, | ||
| due to https://github.com/golemfactory/goth/issues/539. |
There was a problem hiding this comment.
This links to the issue which this PR is going to resolve! I believe the underlying problem in Docker is described here: moby/moby#23302
That's possible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #539
This PR adds the step that explicitly disconnects containers from the
docker_defaultnetwork, using Python Docker SDK. It is equivalent to executing the commandfor each
containerconnected todocker_default.This new step is performed as part of
ComposeNetworkManager.stop_network(), before runningdocker-compose down.