Start probes in parallel #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azawlocki
suggested changes
Jul 26, 2021
goth/runner/__init__.py
Outdated
Comment on lines
185
to
186
| if not future_gather.done(): | ||
| future_gather.cancel() |
There was a problem hiding this comment.
I think future_gather.done() is always true at this point, since await future_gather exited with exception.
OTOH, I'm not sure if cancelling future_gather will have any effects since it's already done(). You probably need to cancel each awaitable explicitly. Anyway, I would test this code thoroughly to make sure that it really does what you think it does.
There was a problem hiding this comment.
Good catch! I've updated this in 4afa05b. There's also an additional condition in test_runner_startup_shutdown which asserts on a log message happening directly after the probe tasks are cancelled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #522