-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output interactive mode env to a file #520
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azawlocki
suggested changes
Jul 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be really grateful if you left the old way of starting the requestor script as an alternative to source'ing the .env file.
azawlocki
approved these changes
Jul 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
kmazurek
force-pushed
the
km/interactive-to-file
branch
2 times, most recently
from
July 27, 2021 19:31
93233f6
to
df9bf01
Compare
kmazurek
force-pushed
the
km/interactive-to-file
branch
from
July 27, 2021 19:35
df9bf01
to
02d6e9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #518
This change makes interactive mode output its environment variables to a file (which can be
source
d), rather than print them out to the console. Example of the file's contents:Known limitations
PATH
extensions are handledsource
d thegftp
script directory is appended to thePATH
variablesubnet tag currently cannot be set through an env variable (perhaps it should be possible?)added toyapapi
in Make engine params configurable via env variables yapapi#546Possible additions
revisit/improve extending thedonePATH
variableadd an integration test for the interactive modedonemention the "new way" in readme/docsdone