Ensure assertion success/failure is reported in EventMonitor #495
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Ensure that assertion success or failure is logged by an event monitor.
Description copied from the docstring in a unit test case added in 9b96799:
Add optional list of
extra_monitors
toRunner.check_assertion_errors()
This would simplify checking errors in monitors created ad hoc, not associated with a probe or an agent.
For example, one
yapapi
integration test ends with:(https://github.com/golemfactory/yapapi/blob/d33d676081a7a29c30b695bb13f7b88c89bc9a46/tests/goth/test_resubscription.py#L190-L191).
After this change, one would be able to write instead:
Add colors to "Running test ..." and "Test finished ..." messages
A bonus. See e.g. https://github.com/golemfactory/goth/runs/2398454134?check_suite_focus=true#step:9:17 and https://github.com/golemfactory/goth/runs/2398454134?check_suite_focus=true#step:9:110.