Variant of payment driver PR that uses custom yagna for one test
#479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azawlocki
force-pushed
the
pay-102-payment-driver-list-with-custom-yagna
branch
from
9ee0297 to
6ee7836
Compare
azawlocki
commented
Apr 9, 2021
Comment on lines
34
to
35
|
|
||
| """Fixture which provides the build environment for yagna Docker images.""" |
There was a problem hiding this comment.
Sorry, forgot to remove the docstring from the default version of the fixture.
pnowosie
approved these changes
Apr 11, 2021
There was a problem hiding this comment.
Original test was approved by @Wiezzel in #453
Closing also my another try (which this PR ia based on) in #470
🙏 Kudos for @azawlocki & @zakaprov for helping me close this 🎉
This was referenced Apr 11, 2021
Closed
azawlocki
force-pushed
the
pay-102-payment-driver-list-with-custom-yagna
branch
from
50579b8 to
18d3c18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A variant of #453 that uses a custom version of yagna (specified as commit hash in a fixture in
test_payment_driver_list_cmd.py).Rebased on
masterto avoid problems with mitmproxy shutdown in short-running tests (see #477).