Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker cleanup steps before and after a test in Actions #475

Merged
merged 2 commits into from
Apr 9, 2021
Merged

Add Docker cleanup steps before and after a test in Actions #475

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64f3b84
Add Docker cleanup steps before and after a test
kmazurek Apr 8, 2021
ff18ce1
Only perform cleanup before a test run
kmazurek Apr 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ jobs:
- name: Install dependencies
run: poetry install --no-root

- name: Remove Docker containers
continue-on-error: true
run: docker rm -f $(docker ps -a -q)

- name: Log in to GitHub Docker repository
run: echo ${{ secrets.GITHUB_TOKEN }} | docker login docker.pkg.github.com -u ${{github.actor}} --password-stdin

Expand Down Expand Up @@ -59,3 +63,7 @@ jobs:
# In future we'll be able to use the `--all` flag here to remove envs for
# all Python versions (https://github.com/python-poetry/poetry/issues/3208).
run: poetry env remove python3.8

- name: Remove Docker containers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zakaprov as discussed, just one cleanup - before the tests - should be enough, right?

continue-on-error: true
run: docker rm -f $(docker ps -a -q)