added ghapi support

[pradeepbbl]

Resolves #384

[kmazurek]

Great start, thanks a lot for your contribution! This works properly when run as part of our integration test suite. :)
Most of the changes look fine, but please take a look at my comments.

Also, I just realised our codestyle CI job is not configured to run on pull requests (again, thanks). You'll need to reformat your code before merging. We use black for formatting and flake8 for linting etc.

Let me know if you have any questions.

[kmazurek]

btw, let me know if you need my assistance in resolving the conflicts before merging.

[pradeepbbl]

nice lint is now running on pull +1

[pradeepbbl]

is something wrong with the test suit was running for the last 1hr?

[kmazurek]

Yes, I stopped the job and cleaned our test runners. Could you please merge the repo's latest master into this branch and try again?

[pradeepbbl]

Not sure looks like something wrong with CI rebase the repo to upstream/master and ran both black and flake8 no issues but failing in runners

$ git rebase upstream/master
Current branch enhancement/384-use-ghapi is up to date.
$ black  .
All done! ✨ 🍰 ✨
77 files left unchanged.
$ flake8 .

[kmazurek]

@pradeepbbl I ran black locally on your latest branch and I'm getting the same errors as reported by CI. Can you please verify your black version? You can do so by running black --version. The project is configured to use version 20.8b1, you should have the same one if you installed it through poetry along with goth.

Otherwise the PR looks good to go! :)

[pradeepbbl]

@zakaprov thanks for the help

[kmazurek]

LGTM! 🥳

Thanks a lot for your contribution! I'll try to tag some more "good first issues" in the repo in case you're interested. :)

[pradeepbbl]

you can directly assign to me if you want ;)