Feature/jst 453 #49
Merged
Feature/jst 453 #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SewerynKras
approved these changes
Oct 6, 2023
| name: "npm", | ||
| }; | ||
|
|
||
| const ua = userAgent ?? process.env["npm_config_user_agent"]; |
There was a problem hiding this comment.
if userAgent === "" this will evaluate to "", is this the expected behavior?
There was a problem hiding this comment.
Yes, if we pass a userAgent, we want to use it, ignoring the env, even if it's empty.
| * | ||
| * @param userAgent Optional user agent. | ||
| */ | ||
| export function getPackageManager(userAgent?: string) { |
There was a problem hiding this comment.
What's the point of this arg if you never use it? (the only call to getPackageManager has no args provided)
There was a problem hiding this comment.
When I get a bit more free time, I'll add an option to command line to specify the package manager.
|
🎉 This PR is included in version 1.1.0-beta.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installs dependencies at the end of
golem-sdk newcommand (if --skip-install is not set)