feat(scan): allow providing runtime name and version as params, support mainnet and testnet preset #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt mainnet and testnet preset
mgordel
approved these changes
Sep 5, 2024
mgordel
deleted the
feature/mainnet-testnet-switch-and-runtime-params-for-scan
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
So that users can do queries such as these:
Changes
Added
--runtime-nameoption to align naming in the SDK and CLI--runtime-versionoption to allow more fine grained scans--testnetoption which is a shorthand for setting other options accordingly for testnet scan--mainnetoption which is a shorthand for setting othe options accordingly for mainnet scanDeprecated
--engineis now deprecated in favour of--runtime-name