Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/jst 396/better passphrase handling #20

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Feature/jst 396/better passphrase handling #20

merged 2 commits into from
Sep 11, 2023

Conversation

pgrzy-golem
Copy link
Contributor

Changes:

  • if key is encrypted, passphrase is required
  • if key is not encrypted, fail if passphrase is provided
  • if key is invalid, print a meaningful error message
  • if passphrase is invalid, print meaningful error message.

@pgrzy-golem pgrzy-golem changed the base branch from master to beta September 11, 2023 08:07
@pgrzy-golem pgrzy-golem requested a review from mgordel September 11, 2023 08:08
@pgrzy-golem pgrzy-golem merged commit 157f889 into beta Sep 11, 2023
@pgrzy-golem pgrzy-golem deleted the feature/JST-396/Better-passphrase-handling branch September 11, 2023 09:10
@github-actions
Copy link

🎉 This PR is included in version 1.0.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgordel mgordel mgordel approved these changes

Assignees
No one assigned
Labels
released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pgrzy-golem @mgordel