Long polling #541
Merged
Long polling #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-polling # Conflicts: # yajsapi/market/demand.ts
…-polling # Conflicts: # yajsapi/payment/payments.ts
pgrzy-golem
reviewed
Aug 16, 2023
| @@ -61,7 +62,10 @@ export class PaymentApiMock extends RequestorApi { | |||
| appSessionId?: string, | |||
| options?: AxiosRequestConfig, | |||
| ): Promise<import("axios").AxiosResponse<InvoiceEvent[]>> { | |||
| return new Promise((res) => res({ data: global.expectedEvents } as AxiosResponse)); | |||
| return new Promise(async (res) => { | |||
| await sleep(100, true); | |||
There was a problem hiding this comment.
why sleep(100) and why 100?
There was a problem hiding this comment.
sleep is to simulate responses returned by long pooling. The current primitive implementation of this mock unfortunately enforces such workarounds to make it work properly
pgrzy-golem
approved these changes
Aug 16, 2023
|
🎉 This PR is included in version 0.8.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.